Toolkit: cdk ls --long #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default "ls" to just print the names of all stacks. The `--long` (or `-l`) switch can be used to emit all data.
|
|
||
| // just print stack names | ||
| for (const stack of stacks) { | ||
| data(stack.name); |
There was a problem hiding this comment.
Why not return stacks.map(s => s.name);?
There was a problem hiding this comment.
Because that will cause a JSON/YAML array to be returned:
- stack1
- stack2
- stack3
And I want an "xargs-compatible" output:
stack1
stack2
stack3
There was a problem hiding this comment.
Oh. As a user I would sometimes find this convenient, sometimes find it confusing. I wonder if long shouldn't be the default, and the xargs-compatible be the option...
Anyway -- that is no blocker.
There was a problem hiding this comment.
I think ls should behave like "ls", where --long is not the default 😉
|
@RomainMuller any other feedback here? |
RomainMuller
approved these changes
Jul 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default "ls" to just print the names of all stacks.
The
--long(or-l) switch can be used to emit all data.